Upgrade to OTEL 1.29.0 #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Dec 13, 2024
| See the `Logfire.instrument_asyncpg` method for details. | ||
| """ | ||
| AsyncPGInstrumentor().instrument( # type: ignore[reportUnknownMemberType] | ||
| AsyncPGInstrumentor().instrument( |
There was a problem hiding this comment.
I'm so happy this got in: open-telemetry/opentelemetry-python-contrib#3084
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 137
Lines 10745 10750 +5
Branches 1472 1473 +1
=========================================
+ Hits 10745 10750 +5 ☔ View full report in Codecov by Sentry. |
Kludex
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies, particularly for the new OTEL release.
Fixes sqlalchemy tests by disabling the SQL commenter because it now adds the comments to
db.statement: open-telemetry/opentelemetry-python-contrib#2937Also I was running into more warnings about checking tokens so I added some more
wait_for_check_token_threadand related code, not related to the rest of the PR.